Make SSL certificate validation respect wildcards#836
Merged
peterbae merged 38 commits intomicrosoft:devfrom Jan 2, 2019
Merged
Make SSL certificate validation respect wildcards#836peterbae merged 38 commits intomicrosoft:devfrom
peterbae merged 38 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #836 +/- ##
============================================
- Coverage 50.17% 50.07% -0.11%
+ Complexity 2919 2912 -7
============================================
Files 120 120
Lines 28085 28112 +27
Branches 4688 4695 +7
============================================
- Hits 14093 14077 -16
- Misses 11711 11750 +39
- Partials 2281 2285 +4
Continue to review full report at Codecov.
|
rene-ye
reviewed
Oct 19, 2018
scovetta
reviewed
Oct 29, 2018
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
scovetta
reviewed
Oct 29, 2018
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
scovetta
reviewed
Oct 29, 2018
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
cheenamalhotra
previously approved these changes
Nov 21, 2018
rene-ye
reviewed
Nov 22, 2018
rene-ye
reviewed
Nov 22, 2018
rene-ye
reviewed
Nov 22, 2018
…thub-816 # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
ulvii
reviewed
Nov 28, 2018
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Show resolved
Hide resolved
cheenamalhotra
approved these changes
Dec 13, 2018
rene-ye
reviewed
Dec 17, 2018
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
… also make sure wildcard is not allowed in top domain
Member
|
@peterbae Please pull changes from PR peterbae#7 |
A different proposal for wildcard certificate matching
cheenamalhotra
previously approved these changes
Jan 2, 2019
rene-ye
previously approved these changes
Jan 2, 2019
rene-ye
approved these changes
Jan 2, 2019
cheenamalhotra
approved these changes
Jan 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #816.
Previously, we needed to use hostNameInCertificate when attempting to make SSL connections to Azure servers because the * (wildcard) character in the SSL certificate from Azure was being processed literally. This change makes it so that the wildcard is actually respected as "any characters".